Added resistance calculation#2476
Merged
Merged
Conversation
marc-flex
force-pushed
the
marc/add_resistance
branch
from
115caea to
14136b0
Compare
…tage input Array-like
marc-flex
force-pushed
the
marc/add_resistance
branch
from
14136b0 to
2af7253
Compare
Contributor
Author
|
So all comments have been tackled. Do have a last look so we can merge @yaugenst-flex I dealt with the changes related using array1D also in the backend, |
momchil-flex
approved these changes
May 23, 2025
yaugenst
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added resistance calculation. Also, allowing ndarrays to be provided as voltage input.
Addresses https://github.com/flexcompute/tidy3d-core/issues/961